-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump envtest, golangci-lint, and kind #6088
Merged
everettraven
merged 2 commits into
operator-framework:master
from
everettraven:bump-envtest
Oct 17, 2022
Merged
bump envtest, golangci-lint, and kind #6088
everettraven
merged 2 commits into
operator-framework:master
from
everettraven:bump-envtest
Oct 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
/hold I need to add a changelog for the ansible changes. |
openshift-ci
bot
added
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 14, 2022
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Indicates that a PR should not merge because someone has issued a /hold command.
label
Oct 17, 2022
grokspawn
approved these changes
Oct 17, 2022
laxmikantbpandhare
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
K8S_VERSION
to be1.25.0
which bumps k8s version used by envtest to be 1.25.0golangci-lint
to be1.50.0
which is the latest and works with Go 1.19kind
to0.16.0
which is the latest and defaults to using k8s 1.25.2 as the node imageReadHeaderTimeout
tohttp.Server
creation logic for ansible.make lint
locally without this lead to linting errors stating that without theReadHeaderTimeout
there is the potential for a Slowloris attack.Motivation for the change:
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs