Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated code and made state as pass and throw suggestion instead of error for missing spec in CR. #6245

Merged
merged 5 commits into from
Jan 11, 2023
Merged

updated code and made state as pass and throw suggestion instead of error for missing spec in CR. #6245

merged 5 commits into from
Jan 11, 2023

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Jan 10, 2023 •
edited

this will fix - #5313

Description of the change:
Removed error and throw suggestion when there is no spec in the CR

Motivation for the change:
In many valid cases, there will not be specs available in the CR

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:27 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare changed the title updated code and made state as pass and thrown suggestions for the same updated code and made state as pass and throw suggestion instead of error for missing spec in CR. Jan 10, 2023
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:32 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:32 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:32 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:39 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:40 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:40 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 20:41 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare
updated code and made state as pass and thrown suggestions for the same
caf7d89 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare
updated code and made state as pass and thrown suggestions for the same
b04f587 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare
updated test cases
427001f 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 10, 2023 21:02 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:24 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:24 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:24 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:24 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:24 — with GitHub Actions Inactive
everettraven
everettraven approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A teeny non-blocking nit. Other than that looks good to me!

/lgtm

changelog/fragments/spec-scoreacrd-fix.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@laxmikantbpandhare
updated according to suggestions
b47f57b 
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

New changes are detected. LGTM label has been removed.

@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare temporarily deployed to deploy January 11, 2023 20:59 — with GitHub Actions Inactive
@laxmikantbpandhare laxmikantbpandhare merged commit a5d933b into operator-framework:master Jan 11, 2023
@laxmikantbpandhare laxmikantbpandhare deleted the spec-warning branch January 11, 2023 20:59
everettraven
everettraven reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@laxmikantbpandhare laxmikantbpandhare added this to the v1.27.0 milestone Jan 11, 2023
@rashmigottipati
Copy link
Member

/cherry-pick v1.25.x

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 24, 2023
Closed
@openshift-cherrypick-robot
Copy link

@rashmigottipati: new pull request created: #6259

In response to this:

/cherry-pick v1.25.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rashmigottipati pushed a commit to rashmigottipati/operator-sdk that referenced this pull request Jan 26, 2023
@laxmikantbpandhare @rashmigottipati
updated code and made state as pass and throw suggestion instead of e…
581633a 
…rror for missing spec in CR. (operator-framework#6245)

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated test cases

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@rashmigottipati rashmigottipati mentioned this pull request Jan 26, 2023
Merged
rashmigottipati pushed a commit to rashmigottipati/operator-sdk that referenced this pull request Jan 26, 2023
@laxmikantbpandhare @rashmigottipati
updated code and made state as pass and throw suggestion instead of e…
832bf51 
…rror for missing spec in CR. (operator-framework#6245)

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated test cases

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati added a commit that referenced this pull request Jan 26, 2023
@rashmigottipati @laxmikantbpandhare
updated code and made state as pass and throw suggestion instead of e…
63935a4 
…rror for missing spec in CR. (#6245) (#6266)

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated code and made state as pass and thrown suggestions for the same

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated test cases

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

* updated according to suggestions

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

@oceanc80 oceanc80 Awaiting requested review from oceanc80

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@everettraven everettraven

@laxmikantbpandhare laxmikantbpandhare

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
v1.27.0
Development

Successfully merging this pull request may close these issues.

Scorecard basic checks is not considering the scenarios where the CRD can be without spec
4 participants
@laxmikantbpandhare @rashmigottipati @openshift-cherrypick-robot @everettraven