-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated code and made state as pass and throw suggestion instead of error for missing spec in CR. #6245
updated code and made state as pass and throw suggestion instead of error for missing spec in CR. #6245
Conversation
d6cf360
to
e401e4d
Compare
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A teeny non-blocking nit. Other than that looks good to me!
/lgtm
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
New changes are detected. LGTM label has been removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherry-pick v1.25.x |
@rashmigottipati: new pull request created: #6259 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…rror for missing spec in CR. (operator-framework#6245) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
…rror for missing spec in CR. (operator-framework#6245) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
…rror for missing spec in CR. (#6245) (#6266) * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated code and made state as pass and thrown suggestions for the same Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated test cases Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> * updated according to suggestions Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com> Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com> Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com>
this will fix - #5313
Description of the change:
Removed error and throw suggestion when there is no spec in the CR
Motivation for the change:
In many valid cases, there will not be specs available in the CR
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs