fixing formatting in 1.25.0 doc and updating install prereq #6253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.19 Signed-off-by: Adam D. Cornett <adc@redhat.com>
everettraven
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
@acornett21 Thanks for the contribution! These changes look good to me!
/lgtm
|
@everettraven I would expect to see this change live in https://v1-26-x.sdk.operatorframework.io/docs/installation/ but it still mentions go 1.18... am I missing something ? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fixing some formatting issues in the 1.25.0 upgrade code and change the instillation prereq to be go 1.19
Motivation for the change:
When following the upgrade from 1.22 to 1.26 I noticed some formating issues in the 1.25.0 doc that caused them to not copy properly, and also missing the need to change from go 1.18 to go 1.19.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsSigned-off-by: Adam D. Cornett adc@redhat.com