Upgrade SDK to use Kubernetes 1.26.2 #6352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmigottipati
commented
Mar 8, 2023
everettraven
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Overall the changes look good to me - great work @rashmigottipati!
The only glaring thing for me is pulling in Kubebuilder 3.9.0 which has a known bug that could break the scaffolding of Go operators.
varshaprasad96
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Just two changes, rest looks good! Thanks for working on this @rashmigottipati :)
/lgtm
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
13 tasks
simararneja
reviewed
Apr 7, 2023
Comment on lines
+38
to
+54
| Regarding the upcoming major changes in the plugin, please note that `go/v3` is being deprecated by Kubebuilder hence Operator SDK would also be migrating to `go/v4` soon. | ||
| Following are the changes to be addressed in your project structure, `Makefile` and `go.mod` files: | ||
| 1) [go/v3, ansible/v1, helm/v1] Update your `go.mod` file to upgrade the dependencies and run `go mod tidy` to download them | ||
| ```go | ||
| k8s.io/api v0.26.2 | ||
| k8s.io/apiextensions-apiserver v0.26.2 | ||
| k8s.io/apimachinery v0.26.2 | ||
| k8s.io/cli-runtime v0.26.2 | ||
| k8s.io/client-go v0.26.2 | ||
| k8s.io/kubectl v0.26.2 | ||
| sigs.k8s.io/controller-runtime v0.14.5 | ||
| sigs.k8s.io/controller-tools v0.11.3 | ||
| sigs.k8s.io/kubebuilder/v3 v3.9.1 | ||
| ``` | ||
| 2) [go/v3, ansible/v1, helm/v1] With the bump to Kubebuilder 3.9.1, the `go/v3` projects are now scaffolded with 0.13.1 version of kube-rbac-proxy. Modify the version of kube-rbac-proxy in the following scaffolded files: | ||
| - config/default/manager_auth_proxy_patch.yaml | ||
| - bundle/manifests/memcached-operator.clusterserviceversion.yaml |
There was a problem hiding this comment.
@rashmigottipati This isn't rendering as expected in the docs https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.28.0/#upgrade-k8s-versions-to-use-126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
go.modandgo.sumresulted from bumping versions to support k8s 1.26.2sets.Stringis used, which has been deprecatedMotivation for the change:
Support for k8s 1.26
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs