configurable engine for container images #6400
Conversation
openshift-merge-robot
added
the
needs-rebase
There was a problem hiding this comment.
@itroyano Thanks for the contribution - I apologize for the long delay in receiving a review. This PR seems to have gotten lost in the ocean of other PRs we had (I've been going through and cleaning them up).
If you don't mind rebasing and resolving any conflicts I'd be happy to approve this PR and work on getting it merged in.
itroyano
force-pushed
the
imageBuilders
branch
2 times, most recently
from
954735e
to
3f8e0e3
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Hi @everettraven, |
|
@itroyano Looks like the DCO check is now failing - if you look at the details of the failing check it should tell you how to resolve it, but the gist is that your commit is missing the sign-off |
|
Added. |
website/content/en/docs/building-operators/ansible/development-tips.md
Outdated
Show resolved
Hide resolved
| @@ -392,6 +392,8 @@ Note that: | |||
| - `operator-sdk generate crds` is replaced with `make manifests`, which generates CRDs and RBAC rules. | |||
| - `operator-sdk build` is replaced with `make docker-build IMG=<some-registry>/<project-name>:<tag>`. | |||
|
|
|||
| `IMAGE_BUILDER` can be used here to specify your container engine. default is `docker`. | |||
There was a problem hiding this comment.
Have we already pulled this in from Kubebuilder in golang, since we are modifying its tutorial here?
There was a problem hiding this comment.
Truth be told I just did a search and replace on all the docs that mention build.
I can remove if it doesn't belong here.
Signed-off-by: Igor Troyanovsky <itroyano@redhat.com>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
I see the latest version added a |
Description of the change:
Allow the container engine to be configurable in the generated Makefile.
Motivation for the change:
For users running Podman or other container runtimes, this adds the capability to run
makecommands with a simple variable specifying their runtime.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs