enable ginkgolinter and fix findings

[nunnatsa]

Description of the change

enable ginkgolinter and fix findings.

Motivation for the change

Improve test code quality and prevent some bug, when using ginkgo and gomega.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[varshaprasad96]

/lgtm

[varshaprasad96]

@nunnatsa looks like the scorecard tests are failing. At a glance looks like the changes in scorecard/ files is as expected. This may also be a flake, hence restarting the tests.

[nunnatsa]

@varshaprasad96 thsnks. I think this test is broken. It constantly fails in my other pr, and also locally from the master branch.

[everettraven]

Thanks for this PR @nunnatsa! All the changes look good to me!

/lgtm

[nunnatsa]

@grokspawn @varshaprasad96 @everettraven - rebased to unblock the CI. Could you please approve again?

[everettraven]

/lgtm

[nunnatsa]

Not sure closing and reopening is enough. I'll rebase

[everettraven]

@nunnatsa Closing and reopening worked. The current failures are unrelated and shouldn't block this PR

[everettraven]

For reference on the failing tests, I created separate issues to track their fixes (#6434 + #6433) and suggest that for the time being we override them where it makes sense

[openshift-ci]

New changes are detected. LGTM label has been removed.

[nunnatsa]

rebased anyway. @everettraven - sorry - missed your coment.

[nunnatsa]

@varshaprasad96, @grokspawn - could you please take another look?

[grokspawn]

/ok-to-test

[grokspawn]

/override ansible/e2e-molecule
/override sanity/docs

These are unrelated; tracked separately by #6433 and #6434

[openshift-ci]

@grokspawn: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• ansible/e2e-molecule
• sanity/docs

Only the following failed contexts/checkruns were expected:

• DCO
• docs
• e2e
• e2e-molecule
• goreleaser
• integration
• netlify/operator-sdk/deploy-preview
• unit

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ansible/e2e-molecule
/override sanity/docs

These are unrelated; tracked separately by #6433 and #6434

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[grokspawn]

/override docs
/override e2e-molecule

(see above)

[openshift-ci]

@grokspawn: Overrode contexts on behalf of grokspawn: docs, e2e-molecule

In response to this:

/override docs
/override e2e-molecule

(see above)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nunnatsa]

🎉