Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically fix scorecard image digests #6429

Closed
wants to merge 3 commits into from

Conversation

nunnatsa
Copy link
Contributor

fix #6428

Description of the change:

  • Add a new tool - the "digester", to retrieve the image digest from the registry.
  • Add a new Makefile target make build-digester to build the new tool
  • Add a new Makefile target make update-scorecard-images to update the hard-coded digests in internal/cmd/operator-sdk/scorecard/cmd.go
  • Add a new github action to periodically check for digests changes and open a PR with an update, if needed. This action can also been run manually from github.

Motivation for the change:
The digests in internal/cmd/operator-sdk/scorecard/cmd.go are hard-coded. Since latest is a floating image tag, then each time a new image is pushed, the digest is changed, and then the scorecard stop working.

This PR is trying to mitigate this, by automatically open a PR to update the digests, each time a new image is pushed.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
…R if need to update them

Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
@nunnatsa nunnatsa changed the title Digester Automatically fix scorecard image digests May 15, 2023
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@nunnatsa nunnatsa temporarily deployed to deploy May 15, 2023 14:47 — with GitHub Actions Inactive
@varshaprasad96 varshaprasad96 added this to the v1.29.0 milestone May 15, 2023
@nunnatsa
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@nunnatsa
Copy link
Contributor Author

not needed. different solution implemented at #6422 and #6425

@nunnatsa
Copy link
Contributor Author

/close

@openshift-ci openshift-ci bot closed this May 16, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2023

@nunnatsa: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nunnatsa nunnatsa deleted the digester branch May 18, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scorecard is failing
2 participants