Set REST timeout when timeout cli arg is provided

[sebsoto]

Description of the change:
The timeout arg sets the overall timeout for the full command to finish, such as run bundle, but it doesn't affect the timeout of individual API server requests. This remains the default timeout specified in the API server configuration. This means that even if a user wants run bundle to timeout after 5m, the command may return earlier due to an individual request's timeout being hit.

This commit fixes that behavior by setting the Timeout value in the client cfg to the value passed in by the user, this will prevent the individual request from timing out before the desired timeout.

Motivation for the change:
operator-sdk bundle run fails on operators that take longer than usual to install

[everettraven]

@sebsoto Thanks for taking the time to write up this contribution! Overall I think the change suggested is reasonable, but I think the existing change doesn't actually address this. I left a comment that elaborates on this a bit more:

[everettraven]

So I think this sounds like a reasonable change, however I think this is being done in the wrong file based on the context given in the PR description. This configuration is only for the operator-sdk olm install command and doesn't apply broadly to all commands.

I can see an argument for applying this more broadly but based on the PR description this change seems to be more focused on updating operator-sdk run bundle and I'd personally prefer to keep this PR scoped to only that command set for now. Having said that, the appropriate place to make this change would likely be in this function:

operator-sdk/internal/olm/operator/config.go

Lines 67 to 113 in 6a6edfd

	func (c *Configuration) Load() error {
	if c.overrides == nil {
	c.overrides = &clientcmd.ConfigOverrides{}
	}
	loadingRules := clientcmd.NewDefaultClientConfigLoadingRules()
	loadingRules.ExplicitPath = c.KubeconfigPath
	mergedConfig, err := loadingRules.Load()
	if err != nil {
	return err
	}
	cfg := clientcmd.NewDefaultClientConfig(*mergedConfig, c.overrides)
	cc, err := cfg.ClientConfig()
	if err != nil {
	return err
	}
	ns, _, err := cfg.Namespace()
	if err != nil {
	return err
	}
	sch := scheme.Scheme
	for _, f := range []func(*runtime.Scheme) error{
	v1alpha1.AddToScheme,
	v1.AddToScheme,
	apiextv1.AddToScheme,
	} {
	if err := f(sch); err != nil {
	return err
	}
	}
	cl, err := client.New(cc, client.Options{
	Scheme: sch,
	})
	if err != nil {
	return err
	}
	c.Scheme = sch
	c.Client = &operatorClient{cl}
	if c.Namespace == "" {
	c.Namespace = ns
	}
	c.RESTConfig = cc
	return nil
	}

IIRC this configuration type is the configuration that is used for both operator-sdk run bundle and operator-sdk run bundle-upgrade commands so modifying this Configuration.Load() function should help address the issue you outlined in the PR description.

[sebsoto]

Thanks for the review, sorry it took so long for me to get back to this. I took a crack at moving the change to the file you suggested.

Please let me know if I'm misusing the overrides struct, I wasn't sure if this would be the correct way to set the timeout.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[sebsoto]

/remove-lifecycle stale

[sebsoto]

@everettraven Could you take another a look at this when you get a chance? Thanks!

[everettraven]

Looks like the actions here are stuck. Going to close and re-open to kick them

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.