-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage recording OverrideValues #6469
Manage recording OverrideValues #6469
Conversation
Signed-off-by: uguendu <ugur.guenduez@mercedes-benz.com>
Signed-off-by: uguendu <ugur.guenduez@mercedes-benz.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/override sanity/docs |
@UgurTheG: UgurTheG unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@UgurTheG: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@everettraven How can I retest sanity / docs (pull_request)? It's the only check failing |
Going to just override the sanity check. I've manually verified that the links work |
Description of the change:
Changes
I made enhancements to the Operator-SDK to include an additional flag to the Helm-Operator. By adding this feature the Event-Recorder will not print/log the Override-Values.
I introduced the
--suppress-override-values
-flag to manage whether or not the OverrideValues are printed/logged. By introducing this flag users that use the helm-operator can be sure that their confidental information in the OverrideValues are not exposed.Motivation for the change:
At Mercedes-Benz, our team is running a Container-as-a-Service (CaaS) platform based on Kubernetes.
We use the helm-operator with confidental OverrideValues which we do not want to be exposed
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs
Ugur Gündüz ugur.guenduez@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, Provider Information