Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage recording OverrideValues #6469

Conversation

UgurTheG
Copy link
Contributor

Description of the change:
Changes
I made enhancements to the Operator-SDK to include an additional flag to the Helm-Operator. By adding this feature the Event-Recorder will not print/log the Override-Values.

I introduced the --suppress-override-values-flag to manage whether or not the OverrideValues are printed/logged. By introducing this flag users that use the helm-operator can be sure that their confidental information in the OverrideValues are not exposed.

Motivation for the change:
At Mercedes-Benz, our team is running a Container-as-a-Service (CaaS) platform based on Kubernetes.
We use the helm-operator with confidental OverrideValues which we do not want to be exposed

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Ugur Gündüz ugur.guenduez@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, Provider Information

Signed-off-by: uguendu <ugur.guenduez@mercedes-benz.com>
Signed-off-by: uguendu <ugur.guenduez@mercedes-benz.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2023
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG UgurTheG temporarily deployed to deploy June 15, 2023 15:32 — with GitHub Actions Inactive
@UgurTheG
Copy link
Contributor Author

/override sanity/docs

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@UgurTheG: UgurTheG unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override sanity/docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@UgurTheG
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@UgurTheG: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@UgurTheG
Copy link
Contributor Author

@everettraven How can I retest sanity / docs (pull_request)? It's the only check failing

@everettraven
Copy link
Contributor

Going to just override the sanity check. I've manually verified that the links work

@everettraven everettraven merged commit 9dd74fb into operator-framework:master Jun 16, 2023
28 checks passed
@UgurTheG UgurTheG deleted the enhancement/suppress-overrideValues branch June 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants