-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RFE-4185: run bundle-upgrade with long image names #6477
Fix RFE-4185: run bundle-upgrade with long image names #6477
Conversation
e4b8482
to
35a4b8d
Compare
35a4b8d
to
80802e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me. Just a couple nits (non-blocking IMO but would be nice to have addressed)
hashBytes := hash.Sum(nil) | ||
return fmt.Sprintf("%x", hashBytes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we shorten this to something like:
hashBytes := hash.Sum(nil) | |
return fmt.Sprintf("%x", hashBytes) | |
return string(hash.Sum(nil)) |
?
If not this is fine, but I think those are equivalent and doesn't require use of the fmt.Sprintf
function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment @everettraven - but these two forms are not equivalent. string(hash.Sum(nil))
will try to use the random bytes as characters. The result is unexpected - we'll end up with wrong UTF-8 chars, non-printable chars and so on.
The original format generates a hex string (2 hex digits per byte), which is a safe string.
Signed-off-by: Nahshon Unna-Tsameret <nunnatsa@redhat.com>
80802e7
to
6609632
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This copies the workflow that is used for the 4.13->4.14 upgrade, using Azure instead of vSphere. Azure is being used as we wish to test storage migration which occurs only for Azure across this upgrade. The operator-sdk version was bumped to include this required fix: operator-framework/operator-sdk#6477 `make update` was ran to generate the presubmit file
This copies the workflow that is used for the 4.13->4.14 upgrade, using Azure instead of vSphere. Azure is being used as we wish to test storage migration which occurs only for Azure across this upgrade. The operator-sdk version was bumped to include this required fix: operator-framework/operator-sdk#6477 `make update` was ran to generate the presubmit file
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
* wmco: bump operator-sdk in release 4.12 This commit updates the operator-sdk version to include a required fix. operator-framework/operator-sdk#6477 * wmco: add azure upgrade test to release 4.12 This commit introduces the azure-e2e-upgrade test in the release 4.12 branch by upgrading from the last released 4.12 bundle to the pipeline bundle.
Fix #6476
Description of the change
In
run bundle-upgrade
, hash the cache directory name to avoid error of too long file name.Motivation for the change
run bundle-upgrade
is failing if the bundle image names are long. See #6476Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs