-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to add annotation to set configure rollback #6546
Merged
OchiengEd
merged 5 commits into
operator-framework:master
from
OchiengEd:configurable-rollback
Sep 11, 2023
Merged
Allow users to add annotation to set configure rollback #6546
OchiengEd
merged 5 commits into
operator-framework:master
from
OchiengEd:configurable-rollback
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to add annotation, "helm.sdk.operatorframework.io/rollback-force", to set rollback to false. Default value is true Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
everettraven
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…-force annotation Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
de5931b
to
6bbe031
Compare
c549cbb
to
d16d463
Compare
Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
d16d463
to
8321420
Compare
varshaprasad96
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Whenever a helm-based operator encounters an error during reconcilliation, by default, it would attempt to perform a rollback with the
--force
option. While this works as expected in most scenarios, there are a few edge cases where performing a rollback with--force
could have undesired side effects.Adding annotation to the custom resource,
helm.sdk.operatorframework.io/rollback-force: false
therefore allows a user, to change the default behavior of the helm-based operator whereby, rollbacks will be performed without the--force
option whenever an error is encountered.%Motivation for the change:
This change was motivated by the issue #6494
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs
Closes #6494