Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor): switch the ansible plugin to use github.com/operator-framework/ansible-operator-plugins, remove ansible code #6583

Merged

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Sep 26, 2023

Description of the change:

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2023
@everettraven everettraven temporarily deployed to deploy September 26, 2023 21:07 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 26, 2023 21:07 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 26, 2023 21:07 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 26, 2023 21:07 — with GitHub Actions Inactive
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy September 27, 2023 13:42 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 13:42 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 13:42 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 13:42 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 13:42 — with GitHub Actions Inactive
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven temporarily deployed to deploy September 27, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 15:24 — with GitHub Actions Inactive
@everettraven everettraven marked this pull request as ready for review September 27, 2023 16:29
@everettraven
Copy link
Contributor Author

Not sure why the e2e-molecule check still shows up as expected. Going to try closing and re-opening to see if it clears it up

@everettraven everettraven reopened this Sep 27, 2023
@everettraven everettraven temporarily deployed to deploy September 27, 2023 16:30 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 16:30 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 16:30 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 16:30 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 16:30 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor Author

everettraven commented Sep 27, 2023

Ah, I just checked the repo settings and it looks like e2e-molecule is marked as a required status from "any source". Will plan to remove it from the required checks once this PR has merged

@everettraven everettraven changed the title WIP: Plugins/ansible swap (refactor): switch the ansible plugin to use github.com/operator-framework/ansible-operator-plugins, remove ansible code Sep 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@everettraven
Copy link
Contributor Author

/override e2e-molecule

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

@everettraven: Overrode contexts on behalf of everettraven: e2e-molecule

In response to this:

/override e2e-molecule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@oceanc80
Copy link
Collaborator

Might want to remove deploy-manual step from the releasing guide. Otherwise lgtm

@everettraven everettraven temporarily deployed to deploy September 27, 2023 20:13 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 20:13 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor Author

@oceanc80 done in 9e10309

@everettraven everettraven temporarily deployed to deploy September 27, 2023 20:13 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 20:13 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy September 27, 2023 20:13 — with GitHub Actions Inactive
@everettraven
Copy link
Contributor Author

/override e2e-molecule

@openshift-ci
Copy link

openshift-ci bot commented Sep 27, 2023

@everettraven: Overrode contexts on behalf of everettraven: e2e-molecule

In response to this:

/override e2e-molecule

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@everettraven everettraven merged commit d21ed64 into operator-framework:master Sep 27, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible Operator Plugin Extraction
3 participants