Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix an issue that multi-arch images cannot be built from the project makefile #6661

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

kurokobo
Copy link
Contributor

Closes #6660

This is the first time for me to send PR to this repository. Please let me know if I'm on the wrong way.
I wasn't sure if a changelog was necessary, but I wrote one anyway.

Thanks in advance 😃

Description of the change:

Fix an issue that multi-arch images cannot be built from the project Makefile, by following two changes:

  • Remove test target from docker-buildx target
  • Remove sed command that adds --platform=${BUILDPLATFORM} so that ${TARGETPLATFORM} is specified as --platform according to BuildKit defaults

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

…ject makefile

Signed-off-by: kurokobo <2920259+kurokobo@users.noreply.github.com>
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @kurokobo ! The changes look good to me visually. Approving and merge will be pending successful CI checks

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@everettraven everettraven merged commit 8721645 into operator-framework:master Jan 22, 2024
23 checks passed
@kurokobo kurokobo deleted the buildx branch January 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"make docker-buildx" does not work as expected for Helm-based operator
2 participants