Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapid reset remediation #6664

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Jan 24, 2024

Description of the change:
Updates dependencies, implementations, testdata, and tests for the default operator-sdk scaffolds and base images for remediation of

Some notable changes:

  • Removal of the go/v3 testdata. This plugin version is deprecated. To keep the testdata and test logic straightforward and easier to maintain, limit the go operator testdata to use go/v4.
  • Updating of the deprecated packagemanifests integration tests to use the go/v4 testdata, which required changing the install modes for OLM v0 to only supporting and installing as AllNamespaces mode due to mutating webhooks being present in the testdata.
  • Bumps k8s dependencies to v0.28.5
  • Bumps Kubebuilder to a commit where the default go/v4 scaffolding includes flags for disabling HTTP/2 on metrics and webhook servers and securely serving the metrics endpoint
  • Bumps controller-runtime to v0.16.3 and includes associated changes.
  • Adds flags to the helm operator controller for disabling HTTP/2 on metrics and webhook server and securely serving the metrics endpoint

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2024
@everettraven everettraven marked this pull request as ready for review January 29, 2024 17:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2024
@everettraven
Copy link
Contributor Author

As mentioned in slack the replace section of the go.mod file can be replaces since all dependency versions there are now past the pinned versions. In my testing in of removing them for1.28 update there were no issues in go vet.

@acornett21 this should be done in b93b680

@everettraven
Copy link
Contributor Author

ot sure if this is planned in another PR, but I think alot of documentation needs to change. I think anything that mentions option.Namespace and anything that talks about cache.MultiNamespacedCacheBuilder. There could be other things, but those are the main ones I see.

I don't think there is currently any PRs planned to update the docs, but I think it would be good to capture any necessary docs update in a new issue to prevent the size of this PR from blowing up any further. Would you mind capturing the problems you've seen as new issues?

Signed-off-by: everettraven <everettraven@gmail.com>
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@everettraven everettraven merged commit 1fd7f4d into operator-framework:master Feb 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants