Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OchiengEd to sdk-approvers #6735

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

OchiengEd
Copy link
Contributor

Description of the change:

Add @OchiengEd to operator sdk approvers

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@OchiengEd OchiengEd requested review from varshaprasad96, joelanford and oceanc80 and removed request for joelanford and oceanc80 April 29, 2024 20:07
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@everettraven
Copy link
Contributor

Sanity check is a flake. Forcing the merge

@everettraven everettraven merged commit 308b320 into operator-framework:master Apr 29, 2024
20 of 21 checks passed
@grokspawn
Copy link
Contributor

Unfortunately, these changes didn't update the .cncf_maintainers file as part of updating OWNERS_ALIASES. Such changes need to re-run make generate. 😞

@grokspawn grokspawn mentioned this pull request May 6, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants