updating to k8s 1.30 dependencies and kubebuilder v4 #6848
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Adam D. Cornett <adc@redhat.com>
| @@ -83,6 +83,7 @@ func NewCmd() *cobra.Command { | |||
|
|
|||
| f.AddTo(cmd.Flags()) | |||
| cmd.Flags().AddGoFlagSet(zapfs) | |||
| cmd.MarkFlagsRequiredTogether("metrics-secure", "metrics-authn-authz") | |||
There was a problem hiding this comment.
This needs to be tweaked. There's a requirement only in one direction. When metrics-authn-authz is specified, metrics-secure must also be specified. However converse is not true.
There might be existing use of metrics-secure in the wild. If we required metrics-authn-authz to be specified with it, all of those existing usages would break.
We want to require that the connection is secure if credentials are exchanged. But if credentials are not exchanged, we don't care about whether the connection is secure.
There was a problem hiding this comment.
So sounds like this would need to be custom if logic, since I don't think cobra offers anything like this, unless you know of something?
There was a problem hiding this comment.
Added the below condition to account for this as an Args function for cobra like we do in other cobra cli's for custom flag validation
c32ccdb#diff-d47d8a84d35cfdd54322d503604e6ff0b2f5454d3f1133bfc4faa8faeb9b476dR78-R83
Signed-off-by: Adam D. Cornett <adc@redhat.com>
acornett21
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
acornett21
changed the title
Description of the change:
Updating go, k8s, kubebuilder and supporting dependencies to the proper version to support go 1.22 and k8s 1.30.
Motivation for the change:
To keep this project aligned with kubbuilder and support k8s 1.30.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs