WIP/POC: pkg/cache;pkg/manager - Adding multi name spaced cache #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
shawn-hurley
commented
Dec 3, 2018
| } | ||
| } | ||
|
|
||
| func (m *multiNamesapceIndexInformer) GetStore() toolscache.Store { |
There was a problem hiding this comment.
@hasbro17 This is the stuff that would be hard to expose. This, GetController and the LastSyncResourceVersion()
I think it may be fine to not have access to the controller or the store. People should very rarely need access to these from what I have seen. (especially the Store). Also have already set up the watches and the like so not having access to the LastSyncResourceVersion or the controller shouldn't cause issues as far as I can tell.
I think that is the biggest drawback from this approach.
|
Closing in favor of kubernetes-sigs/controller-runtime#267 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adding a POC WIP for a multi namespaced PR
Motivation for the change:
Attempt to allow watching multi namespaces