Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Fix misleading bundle instance install failure error message #330

Closed
joelanford opened this issue May 6, 2022 · 2 comments · Fixed by #378
Closed

Fix misleading bundle instance install failure error message #330

joelanford opened this issue May 6, 2022 · 2 comments · Fixed by #378
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@joelanford
Copy link
Member

joelanford commented May 6, 2022

When BI installs fail, the condition message contains something like

uninstall failed: <nil>: original install error: ...

That's a bug in helm-operator-plugins. In this case, there wasn't an uninstall failure at all, so we shouldn't say "uninstall failed: ". I fixed that bug upstream in operator-framework/helm-operator-plugins#159, so we should bump our helm-operator-plugins dependency when that bug fix lands in a release.

@joelanford joelanford added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 6, 2022
@joelanford joelanford added this to the v0.5.0 milestone May 6, 2022
@joelanford joelanford added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 6, 2022
@timflannagan timflannagan modified the milestones: v0.5.0, v0.6.0 May 9, 2022
@timflannagan
Copy link
Contributor

Moving this to v0.6.0 while we wait for the o-f/helm-operators-plugin upstream release.

@joelanford
Copy link
Member Author

Upstream v0.0.10 was just released, so I posted #378 to resolve this. Moving back to v0.5.0 since this seems imminent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants