Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check uninstall error is not nil when uninstalling a failed install #159

Merged
merged 1 commit into from
May 2, 2022

Conversation

joelanford
Copy link
Member

Signed-off-by: Joe Lanford joe.lanford@gmail.com

@coveralls
Copy link

coveralls commented Apr 9, 2022

Pull Request Test Coverage Report for Build 2260159042

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.616%

Totals Coverage Status
Change from base Build 2106897932: 0.0%
Covered Lines: 1562
Relevant Lines: 1743

💛 - Coveralls

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the uninstall-err-check branch 2 times, most recently from 32a41d9 to 4d0a190 Compare April 9, 2022 19:42
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward change. Looks good to me.

@joelanford joelanford closed this May 2, 2022
@joelanford joelanford reopened this May 2, 2022
@joelanford joelanford merged commit b9e775b into operator-framework:main May 2, 2022
@joelanford joelanford deleted the uninstall-err-check branch May 2, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants