Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Add rukpakctl subcommands that utilize local source bundle capabilities. #455

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

akihikokuroda
Copy link
Member

This PR has primitive subcommands for development use.

rukpakctl create bundle - create bundle with the contents of the manifest directory

bin/rukpakctl create bundle test1 testdata/bundles/plain-v0/valid/manifests

rukpakctl create bundledeployment - create bundledeployment with the contents of the manifest directory

bin/rukpakctl create bundledeployment test2 testdata/bundles/plain-v0/valid/manifests

rukpakctl content - show the contents of the bundle

bin/rukpakctl content test1

Signed-off-by: akihikokuroda akuroda@us.ibm.com

@akihikokuroda akihikokuroda requested a review from a team as a code owner July 7, 2022 21:51
Copy link
Member

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I think this is a great start to making rukpakctl a useful tool.

cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundledeployment.go Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/utils/utils.go Outdated Show resolved Hide resolved
@akihikokuroda
Copy link
Member Author

I addressed all comments. They have kubeconfig for the kubernetes cluster access config and namespace for the nemespace of the target or work resources namespace flags now.

Copy link
Member

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is the plan to add some tests as a follow-up?

cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundle.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundledeployment.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundledeployment.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/bundledeployment.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/content.go Outdated Show resolved Hide resolved
cmd/rukpakctl/cmd/create.go Show resolved Hide resolved
@akihikokuroda
Copy link
Member Author

All comments were addressed. The comment about createCmd needs a response. Thanks!

@akihikokuroda
Copy link
Member Author

akihikokuroda commented Jul 12, 2022

Issue for test #459

rukpakctl create bundle <manifest directory> <bundle name prefix>- create bundle with the contents of the manifest directory
rukpakctl create bundledeployment <manifest directory> <bundledeployment name prefix> - create bundledeployment with the contents of the manifest directory
rukpakctl content <bundle name> - show the contents of the bundle

Signed-off-by: akihikokuroda <akuroda@us.ibm.com>
@akihikokuroda akihikokuroda merged commit 93d33a6 into operator-framework:main Jul 14, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants