This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 50
Add rukpakctl subcommands that utilize local source bundle capabilities. #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihikokuroda
force-pushed
the
cli1
branch
3 times, most recently
from
July 8, 2022 00:03
e8105f4
to
38e7194
Compare
exdx
reviewed
Jul 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I think this is a great start to making rukpakctl
a useful tool.
akihikokuroda
force-pushed
the
cli1
branch
3 times, most recently
from
July 12, 2022 17:23
8ece30a
to
bca473b
Compare
I addressed all comments. They have |
exdx
reviewed
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Is the plan to add some tests as a follow-up?
akihikokuroda
force-pushed
the
cli1
branch
2 times, most recently
from
July 12, 2022 21:23
e994e9a
to
abbbfc3
Compare
All comments were addressed. The comment about |
Issue for test #459 |
akihikokuroda
force-pushed
the
cli1
branch
2 times, most recently
from
July 13, 2022 22:36
13cf5de
to
f8018dc
Compare
rukpakctl create bundle <manifest directory> <bundle name prefix>- create bundle with the contents of the manifest directory rukpakctl create bundledeployment <manifest directory> <bundledeployment name prefix> - create bundledeployment with the contents of the manifest directory rukpakctl content <bundle name> - show the contents of the bundle Signed-off-by: akihikokuroda <akuroda@us.ibm.com>
exdx
approved these changes
Jul 14, 2022
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has primitive subcommands for development use.
rukpakctl create bundle - create bundle with the contents of the manifest directory
rukpakctl create bundledeployment - create bundledeployment with the contents of the manifest directory
rukpakctl content - show the contents of the bundle
Signed-off-by: akihikokuroda akuroda@us.ibm.com