This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
rukpakctl: remove use of globals and exported types; use contexts consistently #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
local-source-fixup-pt1
branch
from
1be7e93
to
c0c5e74
Compare
tylerslaton
approved these changes
Jul 26, 2022
akihikokuroda
approved these changes
Jul 26, 2022
|
|
||
| "github.com/spf13/cobra" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/client-go/kubernetes" | ||
| "k8s.io/client-go/tools/clientcmd" |
timflannagan
approved these changes
Jul 26, 2022
…sistently Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
local-source-fixup-pt1
branch
from
c0c5e74
to
7d91ab9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 1 of making some improvements discussed in #464, which is a minor refactoring of the rukpakctl commands to remove global vars and unnecessarily exported types.
I also uncovered a few places we should be passing contexts down, so I've made those fixes as well.
Step 2 will follow up with further changes, to include:
localtoconfigmapsSigned-off-by: Joe Lanford joe.lanford@gmail.com