Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve/rename local source to support multiple configmaps #611

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

joelanford
Copy link
Member

Closes #464
Closes #590

I had this code sitting in an old branch, and I didn't want to lose it. So here it is!

  • renamed "local" source to "configMaps"
  • changed source API to accept multiple configmaps, each with a corresponding directory path at which to mount the configmap data in the bundle
  • updated unpacker to use a separate client/cache which is capable of watching all objects in the rukpak system namespace, but in the rukpak system namespace only. we use a cluster-scoped watch with label selectors to watch bundles, BDs, and BD operand manifest objects, and now this adds a second cache for rukpak-system namespace so that we can watch/cache anything rukpak itself needs to run/fulfill its API.
  • added a webhook for configmaps to ensure (some of the) expected invariants are met. This PR has some TODO comments for follow-ups we could do.

@joelanford joelanford requested a review from a team as a code owner March 29, 2023 03:13
- new name is "configmaps"
- updated unpacker to use a separate client/cache which is capable
  of watching all objects in the rukpak system namespace
- added a webhook for bundles and configmaps to ensure expected
  invariants around bundle immutability are met.
…licate path detection

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford merged commit 54907fb into operator-framework:main Apr 11, 2023
@joelanford joelanford deleted the configmaps-source branch April 11, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The plain provisioner doesn't reconcile changes to a local configmap Improve the local source type
2 participants