-
Notifications
You must be signed in to change notification settings - Fork 50
Add a CRD Upgrade Safety preflight check to the BundleDeployment
controller
#873
Add a CRD Upgrade Safety preflight check to the BundleDeployment
controller
#873
Conversation
db14475
to
97fd561
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 15.06% 14.55% -0.52%
==========================================
Files 40 41 +1
Lines 2443 2529 +86
==========================================
Hits 368 368
- Misses 2018 2104 +86
Partials 57 57 ☔ View full report in Codecov by Sentry. |
3d4d5b5
to
70a5e18
Compare
21cd9e6
to
3d643ee
Compare
BundleDeployment
controller
043a1ae
to
a01ed84
Compare
@@ -101,6 +101,12 @@ func WithActionClientGetter(acg helmclient.ActionClientGetter) Option { | |||
} | |||
} | |||
|
|||
func WithPreflights(preflights ...Preflight) Option { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Is this required and present by default for now? If so, it would be nice to add a validation for this in validateConfig
func, just to avoid programmer's error since we are calling preflight.Install
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not required. If there are no preflight checks defined neither preflight.Install()
nor preflight.Upgrade()
should be called.
a01ed84
to
1d2aab8
Compare
1117d74
to
595b5c2
Compare
Signed-off-by: everettraven <everettraven@gmail.com>
595b5c2
to
e2ba479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
96043d4
Description:
preflights/crdupgradesafety
package containing the logic for a CRD Upgrade Safety preflight checkBundleDeployment
controller to be able to be configured with preflight checks and runs them if they are configured