Skip to content
This repository has been archived by the owner on Aug 12, 2024. It is now read-only.

Makefile: avoid re-evaluating vars unnecessarily; other minor fixup #877

Merged

Conversation

joelanford
Copy link
Member

Fixes #875

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner May 2, 2024 21:04
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.27%. Comparing base (f9cee1a) to head (ca4ce93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #877   +/-   ##
=======================================
  Coverage   37.27%   37.27%           
=======================================
  Files           9        9           
  Lines         845      845           
=======================================
  Hits          315      315           
  Misses        486      486           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

I'm still not 100% sold on replacing ?= statements with the likes of

ifeq ($(origin IMAGE_REPO), undefined)
include .bingo/Variables.mk
IMAGE_REPO := quay.io/operator-framework/rukpak
endif

since according to gnu make these are equivalent. Any other behavior should be considered a bug in the tool.

However, as with the related PRs there are lots of other improvements which tangibly improve make interactions, so I'm content to agree-to-disagree on this point. 😄

@grokspawn grokspawn added this pull request to the merge queue May 7, 2024
Merged via the queue into operator-framework:main with commit d747ca9 May 7, 2024
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Makefile to avoid unnecessarily shelling out multiple times for the same variables
2 participants