Add optional field to BundleDeployment API to enable/disable CRD upgrade safety preflight checks #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 14.55% 14.41% -0.14%
==========================================
Files 41 41
Lines 2529 2553 +24
==========================================
Hits 368 368
- Misses 2104 2128 +24
Partials 57 57 ☔ View full report in Codecov by Sentry. |
everettraven
previously approved these changes
May 21, 2024
There was a problem hiding this comment.
These changes look good to me.
I'll hold on merging this for a bit to give @joelanford a chance to review in case he has any additional comments
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
joelanford
reviewed
May 22, 2024
rashmigottipati
force-pushed
the
configure-crd-checks
branch
2 times, most recently
from
c3f5740
to
19f0d0d
Compare
everettraven
previously approved these changes
May 23, 2024
joelanford
reviewed
May 23, 2024
rashmigottipati
force-pushed
the
configure-crd-checks
branch
from
19f0d0d
to
c7eb026
Compare
joelanford
approved these changes
May 29, 2024
…ade safety preflight checks Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
rashmigottipati
force-pushed
the
configure-crd-checks
branch
from
7f8e509
to
84010f8
Compare
Merged
via the queue into
operator-framework:main
with commit May 29, 2024
f5b290a
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new, optional field to the
BundleDeploymentAPI spec for enabling/disabling the CRD Upgrade Safety preflight checks. The default state should be enabled.No logic included in this PR as the CRD Upgrade Safety preflight check as there isn't anything yet to enable/disable. So logic to enable/disable will be added in a follow-up
fixes operator-framework/operator-controller#745
original PR in operator-controller: operator-framework/operator-controller#845