This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Update certificate support #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is necessary to get certs work on a per- |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 14.44% 14.42% -0.03%
==========================================
Files 41 41
Lines 2554 2558 +4
==========================================
Hits 369 369
- Misses 2128 2132 +4
Partials 57 57 ☔ View full report in Codecov by Sentry. |
Remove `rootCAs` from the `NewDefaultUnpacker` API, the argument is no longer used for HTTP transport. Add `CertificateData` to the ImageSource struct. This is PEM-encoded data (straight from a Secret[tls.crt]) to be used to validate the certificate used to access an image regidstry (works along side the `InsecureSkipTLSVerify` option). Signed-off-by: Todd Short <todd.short@me.com>
|
The code is tested in the e2e, but that doesn't count toward code coverage. |
Merged
via the queue into
operator-framework:main
with commit Jun 18, 2024
e1d8b0e
7 of 10 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
rootCAsfrom theNewDefaultUnpackerAPI, the argument is no longer used for HTTP transport.Add
CertificateDatato the ImageSource struct. This is PEM-encoded data (straight from a Secret[tls.crt]) to be used to validate the certificate used to access an image regidstry (works along side theInsecureSkipTLSVerifyoption).