Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet amount condition and fi status when giving up #446

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Fix wallet amount condition and fi status when giving up #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .../main/kotlin/co/nilin/opex/accountant/ports/postgres/impl/FinancialActionPersisterImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,15 @@ class FinancialActionPersisterImpl(
//Do nothing
} else {
with(retryModel) {
val giveUp = retries + 1 >= retryCount
faRetryRepository.scheduleNext(
id!!,
retries + 1,
LocalDateTime.now().plusSeconds(retries * delayMultiplier * delaySeconds),
retries >= retryCount
giveUp
).awaitSingleOrNull()

if (hasGivenUp)
if (giveUp)
status = FinancialActionStatus.ERROR
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...er-postgres/src/main/kotlin/co/nilin/opex/wallet/ports/postgres/impl/WalletManagerImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class WalletManagerImpl(
}

override suspend fun isWithdrawAllowed(wallet: Wallet, amount: BigDecimal): Boolean {
if (amount <= BigDecimal.ZERO)
if (amount < BigDecimal.ZERO)
throw OpexError.InvalidAmount.exception()

var evaluate = wallet.balance.amount >= amount
Expand Down
Loading