Clean up deposit withdraw services #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatemeh-i
approved these changes
Sep 17, 2024
fatemeh-i
added a commit
that referenced
this pull request
Oct 23, 2024
* Remove pulling dev branch in otc workflow (#462) * Remove pulling dev branch in otc workflow * Remove pulling dev branch in otc workflow * Upgrade error-hanlder.version * Replace user_transctions with transactions for external use (#463) * Remove details from fiActions in wallet and accountant * Use enum for withdraw status * Use enum for more hardcoded variables * Use enum for transfer category * Modify database * Add try catch in wallet BackupService * FinancialActionJobKafka TBC * Adding rest services * Add admin tx for DEPOSIT_MANUALLY * Remove balance_before * Change fi_actions transfer ref to use uuid * Fix test failure * Fix type mismatch error * Make one test function suspended * Fix quote asset not included in estimated value * Edit schema Transaction refactor completed * Replace docker-compose with docker compose in workflows * Start to handle different type of gateways for currencies * Implement requred services for all type of gateways * Complete create new gateway service * Complete gateway services * Fix bug of currency creation * Fix bug of currency creation * Fix bug of currency creation * Refactor withdraw services (#464) * Start refactoring withdraw * Remove applied_fee Refactor withdraw service * Delete deprecated services * Add fee service * Fix amount mismatch * Fix user transaction service * Change getUserTransactions http method * - * Fix dependency bug * Fix schema.sql for old DB version * Set scale for Division Calculations * Set withdraw/deposit allowed field in a currency object using detail of it's gateways * Set withdraw/deposit allowed field in a currency object using detail of it's gateways * Clean up deposit withdraw services (#466) * Simplified deposit services * Clean up withdraw services * Fix quote asset not considered in total assets * Add docker compose instead of docker-compose in actions scripts * try to merge * add availableGatewayType to currency object * docker-compose -> docker compose (#471) * docker-compose -> docker compose * rm prefrences config from otc profile * Rm isCryptoCurrency field from currency class * Rm isCryptoCurrency field from currency class * Try to debug wrong value in availableGatewayType * Try to debug wrong value in availableGatewayType * Try to debug wrong value in availableGatewayType * Solve bug in having wrong value for availableGatewayType * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Replace main with MAIN in wallet proxy * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Try to solve diffrent merge conflicts * Set default value for advanced transfer * Transfer ref is not nullable field * Set default value for wallet type in advanced transfer * Set default value for wallet type in advanced transfer * Add swap category to user transactions history * Support get transactions history by admin * Fix change in balance calculation for swap category * sync * Add last update date and applicator to withdraw model * Add last update date and applicator to withdraw model * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Handle off-chain withdraw request * Set default message in error handling process * refactor deposit's endpoints * Fetch seaps history for user and admin * Develop services to get history for transfer-based actions for trusted users and admins * Fix ithdrw search query * Fix withdrow search query * Fix withdrow search query * Fix withdrow search query * Fix withdrow search query * Fix deposit search param * Change swap history services * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Fix query of swap history * Change in swap hitory detail * - * - * - * - * Alter table -> - * - * Fix a calculation issue in swap history * Consider attachment field for withdraw/deposit actions --------- Co-authored-by: Peyman <peyman.sepehrad@gmail.com> Co-authored-by: Peyman <marchosiax@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.