[58414] When you click on the "To the Notification Center" button, an outline appears

[bsatarnejad]

When clicking on an octicon, there is an outline around it, it is related to the tabIndex set to it.
We need to remove it from the component.

https://community.openproject.org/projects/openproject/work_packages/58414/activity

[changeset-bot]

🦋 Changeset detected

Latest commit: ab73b6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@openproject/octicons	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[HDinger]

Hi @bsatarnejad

please do not touch the react code, as it is coming directly from Primer and will only cause merge conflicts if we touch it. Further, we are not using the React components at all..
Looking however at the react code, I notifced that the tabIndex is optional there with no default set. So if we aim for consistency, we should probably still allow the tabIndex but not set a default. What do you think?

[bsatarnejad]

Hi @bsatarnejad

please do not touch the react code, as it is coming directly from Primer and will only cause merge conflicts if we touch it. Further, we are not using the React components at all.. Looking however at the react code, I notifced that the tabIndex is optional there with no default set. So if we aim for consistency, we should probably still allow the tabIndex but not set a default. What do you think?

Hi @HDinger
I agree with making tabIndex optional in the sake of consistency. 👍

[HDinger]

I just have one minor remark. Otherwise it is looking fine 👍