Feature/44702 team planner add work week option to visible time scale #11601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulferts
force-pushed
the
feature/44702-team-planner-add-work-week-option-to-visible-time-scale
branch
2 times, most recently
from
7f78fcb
to
171aebd
Compare
ulferts
force-pushed
the
feature/44702-team-planner-add-work-week-option-to-visible-time-scale
branch
from
171aebd
to
844778b
Compare
|
I'm willing to accept this approach, but we should note that the assumed translation "Wochentage" in German already ellipses and will probably be commented on by product?
|
b12f
suggested changes
Nov 10, 2022
frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.html
Show resolved
Hide resolved
frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.html
Show resolved
Hide resolved
frontend/src/app/features/team-planner/team-planner/planner/team-planner.component.ts
Outdated
Show resolved
Hide resolved
oliverguenther
deleted the
feature/44702-team-planner-add-work-week-option-to-visible-time-scale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dropdown to switch between the various views provided by the team planner in favor of the toggle that existed before. Also adds a 'Work week' view which becomes the new default.
https://community.openproject.org/wp/44702
Because adding a custom button via fullcalendar is quite limited, the toggle is moved to the appropriate position by css. This is a solution that just might be good enough. It e.g. has the drawback of requiring to set a fixed width for the button which might lead to the currently selected view name being abbreviated. The alternative of having a flexible width would have required reimplement the whole header.