[old branch] Attempt to fix User circular dependency auto-loading #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When User is loaded first, try to emulate the behavior as if Principal was loaded first. Conflicts: app/models/user.rb
|
@meeee (you are mentioned, because you have commits in this PR) I will delete this PR and the branch next monday if no one complains. If you care about the changes in this PR (or you know someone who does), hinder me. |
|
I'm still interested in this and I'd still love feedback from someone. No one had the courage to comment on the original PR: #263 If someone wants to take a look at this, I'll be happy to rebase the changes onto dev. |
|
So, I'm no longer interested in pursuing this and apparently no one else is. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When User is loaded first, try to emulate the behavior as if Principal was loaded first.
Conflicts:
app/models/user.rb
ℹ️ This is a maintenance PullRequest1
The following actions may be done:
dev; test it1: This PR was created to reduce the huge number of stale branches (branches which are older than 6 month and don't have a pull request). The goal is to give those branches a platform for review and discussion and -- on the long term -- either integrate or delete them.