Fix Ajax Session loss Feature for 401 Standard Conformity #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| format.any(:xml, :js, :json) { head :unauthorized, "Reason" => "login needed", 'WWW-Authenticate' => 'Session realm="OpenProject API"' } | ||
| else | ||
| format.any(:xml, :js, :json) { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="OpenProject API"' } | ||
| end |
There was a problem hiding this comment.
Assuming you didn't remove the "Reason" => "login needed" on purpose, I'd suggest this code
authentication_scheme = if request.headers["X-ACCEPT-AUTH"] == "Session"
'Session' else 'Basic'
end
format.any(:xml, :js, :json) { head :unauthorized,
"Reason" => "login needed",
'WWW-Authenticate' => authentication_scheme + ' realm="OpenProject API"' }There was a problem hiding this comment.
You are right. I changed the code.
|
I'd like to have a test for the new header. Any reason you chose the all-caps |
|
|
||
| authentication_scheme = if request.headers["X-Authentication-Scheme"] == "Session" | ||
| 'Session' else 'Basic' | ||
| end |
There was a problem hiding this comment.
You should correct the intendation:
authentication_scheme = if request.headers["X-Authentication-Scheme"] == "Session"
'Session' else 'Basic'
end
|
Please merge after indentation is fixed and updating the changelog. |
This reverts commit 9ede533.
nkenneweg
added a commit
that referenced
this pull request
Jul 4, 2013
nkenneweg
added a commit
that referenced
this pull request
May 13, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be subject to discussion!
@meeee @Cnrk @tessi