No more acts_as_tree in planning elements. #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one somehow got lost. But it definitely belongs here.
Previously, destroy! would do what destroy formerly did, and destroy would move to trash. Now trash trashes stuff into the recycle bin and destroy destroys from DB.
Testing circular dependencies is part of awesome_nested_set. Also, this test is rather bad catching StaleObjectErrors.
ulferts
added a commit
that referenced
this pull request
Jul 18, 2013
No more acts_as_tree in planning elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leaves awesome_nested_set in work packages to be the only tree implementation in issues, planning elements and work packages. This also required changing the recycle bin API and the specs.