Some smaller refactorings #3370
Conversation
|
I've prepared a stage to preview changes. Open stage or view logs. |
| format.html do render layout: false end | ||
| format.any(:xml, :json) { render request.format.to_sym => wp_hashes_with_string } | ||
| format.html { render layout: false } | ||
| format.any(:xml, :json) { render request.format.to_sym => wp_hashes_with_string(@work_packages) } |
|
Thinking about it: d0426dc probably conflicts with the Rails 4 upgrade. I can remove that commit if it causes conflicts. |
| @@ -43,7 +43,7 @@ def create | |||
| author: user, | |||
| type: project.types.where(is_default: true).first || project.types.first | |||
| } | |||
| self.work_package = project.add_work_package(hash) | |||
There was a problem hiding this comment.
good catch! I thought, that we stopped remembering the own work package, long ago...
Nice to see, that you are thinking about that. But we can't stop introducing |
| @@ -55,14 +55,14 @@ def index | |||
|
|
|||
| respond_to do |format| | |||
| format.html do render layout: false end | |||
| format.any(:xml, :json) { render request.format.to_sym => wp_hashes_with_string } | |||
| format.any(:xml, :json) { render request.format.to_sym => wp_hashes_with_string(@work_packages) } | |||
|
@NobodysNightmare I removed the block style change and force pushed the branch. Feel free to merge it. |
Some smaller refactorings
|
I feel that I merged this PR prematurely
Investigating... edit: Okay, it has apparently been an error when merging this PR with the rails4 branch... |
|
so what's the state here? still an error or not? |
|
Oh, nono... my edit was probably not clear enough. It was an error with the merge immediately following the merge of this PR. And the error was fixed immediately. So nothing to worry about on this PR :) |
This is just some stuff I found while getting to know the code base. IMO none of the changes should be controversial and the PR is mergeable as is, unless Travis disagrees with me.