Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop replacing links inside macros #340

Merged
merged 2 commits into from
Aug 21, 2013

Conversation

mugwump
Copy link
Contributor

@mugwump mugwump commented Aug 20, 2013

The textile-formatter runs before the macros: If a macro uses a url as a parameter (e.g. to {{embed_youtube(http://www.youtube.com/watch?v=bqzQ2qrtBeg)}} then these urls are replaced with an inline link (rendering them unusable: e.g. {{embed_youtube(<a href="..." ) - the commit makes sure, that urls inside macros remain untouched.

The textile-formatter runs before the macros: If a macro uses a url as a
parameter (e.g. to
{{embed_youtube(http://www.youtube.com/watch?v=bqzQ2qrtBeg)}} then these
urls where replaced with an inline link (<a href="...") - the commit
makes sure, that urls inside macros remain untouched.
cratz pushed a commit that referenced this pull request Aug 21, 2013
…acros

Stop replacing links inside macros
@cratz cratz merged commit 89e9cc9 into feature/rails3 Aug 21, 2013
@cratz cratz deleted the feature/rails3_no_inline_links_for_macros branch August 21, 2013 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants