[FEATURE] Migrate calendars controller test.rb #434
Conversation
|
Travis doesn't like it:
|
| @@ -206,10 +206,6 @@ | |||
| # work as a catchall for everything under /wiki | |||
| get 'wiki' => "wiki#show" | |||
|
|
|||
| namespace :issues do | |||
| resources :calendar, :controller => 'calendars', :only => [:index] | |||
There was a problem hiding this comment.
You deleted the route for
/projects/:project_id/issues/calendar
and added one for
/work_packages/calendar
There is still a route defined for
/issues/calendar
while the one for
/projects/:project_id/work_packages/calendar
is missing. The test for that route is missing, too.
This results in the url for the calendar menu entry beeing displayed as e.g.
/work_packages/calendar?project_id=openproject
|
There is an occurrence of "issues/calendar" in app/views/welcome/robots.text.erb While this file appears to be maintained less good, this is a chance to get better. |
|
Works as expected, otherwise. Fix the points mentioned and give me a ping. I will merge it. |
|
@ulferts Thanks for the hint! You seem to see everything! 🔍 And yeah, 🔔 PING! |
…_test.rb [FEATURE] Migrate calendars controller test.rb
Implements ticket 2057