Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIGRATION] Prepare schema migration table #457

Merged

Conversation

hschink
Copy link
Contributor

@hschink hschink commented Sep 25, 2013

Implements ticket 1992

@ghost ghost assigned apfelfabrik Sep 25, 2013
@apfelfabrik
Copy link
Contributor

The confirmation dialog is a good idea, but only if the shell is interactive. Rake tasks tend to be executed in deployment scripts, especially those that are built around migrations. So I would suggest one of the following:

  • remove the confirmations or
  • check whether the shell is interactive [1].

I believe @cratz is with me on this one :-)

[1] http://stackoverflow.com/questions/3384982/how-can-i-determine-if-my-process-is-being-run-interactively

@apfelfabrik
Copy link
Contributor

There are other issues here. Some of the rake tasks seem to have dependencies to migrations that couldn't be run before others of the rake tasks were executed. I am commenting ticket 1992.

@apfelfabrik
Copy link
Contributor

One more thing: migrations:documents:delete and migrations:attachments:delete_from_projects_and_versions both state they'd be deleting all documents. Only one of those statements can be true, I suppose.

@hschink
Copy link
Contributor Author

hschink commented Sep 30, 2013

@apfelfabrik: Documents and attachments are two different things, thus, only one rake task is actually stating it is deleting documents. The other one deletes attachments (from versions and projects).

@apfelfabrik
Copy link
Contributor

I have restarted the failed travis build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants