refactor(common): move inventory to separate folder #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
=====================================
Coverage 7.87% 7.87%
=====================================
Files 13 13
Lines 2058 2058
=====================================
Hits 162 162
Misses 1878 1878
Partials 18 18
|
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
glimchb
reviewed
Oct 16, 2023
| @@ -8,7 +8,7 @@ package mocks | |||
| import ( | |||
| context "context" | |||
|
|
|||
| _go "github.com/opiproject/opi-api/common/v1/gen/go" | |||
There was a problem hiding this comment.
this doesn't look auto-generated, can you please run make ?
glimchb
reviewed
Oct 16, 2023
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving inventory from common to separate folder to allow for future additions such as capabilities protobuf and to support the autogeneration of protobuf files using 'buf'