Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add create/delete cli calls for virtio-blk controllers #427

Merged
merged 5 commits into from
Jan 16, 2024
Merged

feat(storage): add create/delete cli calls for virtio-blk controllers #427

merged 5 commits into from
Jan 16, 2024

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Jan 15, 2024 •
edited
Loading 

blk0=$(/dpu storage create virtio blk --id virtioblk0 --pf 0 --vf 0 --volume "$vol0")
/dpu storage delete virtio blk --name "$blk0"

@artek-koltun
feat(storage/virtio-blk): add create virtio-blk cmd
9592c58 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
test(storage/virtio-blk): add client create virtio-blk tests
e71086b 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
feat(storage/virtio-blk): add delete virtio-blk cmd
9bef46e 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
test(storage/virtio-blk): add client delete virtio-blk tests
ab81fcd 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun
refactor(storage): rename create*Client to createFrontend*Client
9b0d83b 
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review January 15, 2024 12:50
@artek-koltun artek-koltun requested a review from a team as a code owner January 15, 2024 12:50
sandersms
sandersms approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sandersms sandersms merged commit 86b9fb1 into opiproject:main Jan 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersms sandersms sandersms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@artek-koltun @sandersms