Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): remove unused timout from client #429

Merged

Conversation

artek-koltun
Copy link
Collaborator

Context is used to set timeout

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86b9fb1) 37.03% compared to head (9ba0ec1) 37.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   37.03%   37.00%   -0.03%     
==========================================
  Files          19       19              
  Lines        2290     2289       -1     
==========================================
- Hits          848      847       -1     
  Misses       1409     1409              
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun marked this pull request as ready for review January 16, 2024 14:27
@artek-koltun artek-koltun requested a review from a team as a code owner January 16, 2024 14:27
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artek-koltun artek-koltun force-pushed the refactor-remove-unused-timeout branch from fca0026 to 9ba0ec1 Compare January 17, 2024 07:16
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun merged commit f0d182f into opiproject:main Jan 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants