-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(storage): adjust storage structure to add backend api #430
refactor(storage): adjust storage structure to add backend api #430
Conversation
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
===========================================
+ Coverage 36.84% 66.43% +29.58%
===========================================
Files 19 15 -4
Lines 2299 1275 -1024
===========================================
Hits 847 847
+ Misses 1419 395 -1024
Partials 33 33 ☔ View full report in Codecov by Sentry. |
cmd/storage/frontend/frontend.go
Outdated
|
||
// NewStorageCommand tests the storage functionality | ||
func NewStorageCommand() *cobra.Command { | ||
// NewCreateCommand creates a new command to delete frontend resources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to create
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, found just one typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one failing check to resolve
d102264
to
ba85295
Compare
Align with API structure and prepare to introducing backend Nvme Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Sort out storage files to corresponding dirs since the number of file is growing, and it is getting harder to comprehend their structure. It was decided to stick to existing storage API separation for
frontend
/middlend
/backend
.The directory structure in
cmd
mirrors the structure in the rootstorage
libaray package to make it easier to match the related code.Added
frontend
cmdline option in a separate commit to prepare to addingbackend
nvme part.The
inventory
,ipsec
,evpn
code fromcmd
will be moved to corresponding dirs in the follow-up PRs.Exemplary cmd set
Waiting for opiproject/opi-spdk-bridge#837 to pass CI