Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage/nvme): add cli for nvme controller #432

Merged

Conversation

artek-koltun
Copy link
Collaborator

@artek-koltun artek-koltun commented Jan 19, 2024

Exemplary cmd:

nvmf0=$(/dpu storage create backend nvme controller --id nvmf0 --multipath failover)
/dpu storage delete backend nvme controller --name "$nvmf0"

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (742ee44) 66.43% compared to head (3c01831) 67.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
+ Coverage   66.43%   67.64%   +1.21%     
==========================================
  Files          15       17       +2     
  Lines        1275     1323      +48     
==========================================
+ Hits          847      895      +48     
  Misses        395      395              
  Partials       33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun force-pushed the feat-add-cli-for-nvme-remote-controller branch from 1455fe3 to 3c01831 Compare January 19, 2024 12:35
@artek-koltun artek-koltun marked this pull request as ready for review January 19, 2024 12:40
@artek-koltun artek-koltun requested a review from a team as a code owner January 19, 2024 12:40
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandersms sandersms merged commit 439e5fc into opiproject:main Jan 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants