-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): set annotations for backend #330
feat(storage): set annotations for backend #330
Conversation
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the annotations looks ok, but creating new message TcpController
should be discussed and in a separate PR
ok, I can remove |
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun yes, please remove |
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
See #198 and AIP-203
First, let's try to discuss where we are going to keep functionality to connect to local Nvme PCIe drives for JBOF case, since it would affect how to annotate the fields properly. I see an empty separate backend_nvme_pcie.proto, but also I see
NVME_TRANSPORT_PCIE
enum value inNvmeTransportType
in backend_nvme_tcp.proto file, which might imply reuse of the service for PCIe.Some assumptions/considerations in the first patch:
NvmeRemoteControllerService
for PCIeFabricsPath
message was created, which is part ofNvmePath
. It allows to annotate some fields asREQUIRED
for Nvme over fabrics transport types and have more consistent API. Otherwise, we need to keep themOPTIONAL
, since we can use the same API to connect to local PCIe.TcpController
was created to be consistent with previous item and isolateTCP
related optional parameters. This message is a part ofNvmeRemoteController
.