feat(idpool): idpool feature for generating id's #400
Conversation
pkg/LinuxGeneralModule/lgm.go
Outdated
| @@ -465,8 +467,12 @@ func setUpVrf(vrf *infradb.Vrf) (string, bool) { | |||
| vrf.Metadata.RoutingTable = make([]*uint32, 1) | |||
| vrf.Metadata.RoutingTable[0] = new(uint32) | |||
| var routingTable uint32 | |||
| Name := vrf.Name | |||
There was a problem hiding this comment.
please align with Go style guide:
https://google.github.io/styleguide/go/decisions.html
There was a problem hiding this comment.
I think you overshot it :)
why _unusedids? It is almost unreadable. Use lower case for not exported members. Use camelCase naming. Do not use _ in names.
pkg/utils/Idpool.go
Outdated
| _unusedIDs []uint32 // Yet unused IDs in pool Available ids | ||
| _idsInUse map[interface{}]uint32 // Mapping key: id for currently assigned ids | ||
| _idsForReuse map[interface{}]uint32 // Mapping key: id for previously assigned ids | ||
| _refs map[uint32][]interface{} |
There was a problem hiding this comment.
refs sounds like a counter tracking how many times we requested the same id, no?
There was a problem hiding this comment.
correct, its reference to the same id
There was a problem hiding this comment.
then why do we need a slice of slices then? Can we have a slice of counters? map[uint32]uint32?
There was a problem hiding this comment.
actually we need golang type equivalent of 'list' type in python.
we have replaced with "ref map[uint32]map[interface{}]bool"
here the scenario is for same key we can have different references of interface type as reference can be of any type like int, string, alphanumeric etc. that's why we cannot use counter here.
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
3 times, most recently
from
eb45583
to
45ace4d
Compare
pkg/utils/idpool.go
Outdated
| // Copyright (c) 2022-2023 Intel Corporation, or its subsidiaries. | ||
| // Copyright (C) 2023 Nordix Foundation. | ||
|
|
||
| // Package linuxgeneralmodule is the main package of the application |
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
4 times, most recently
from
ed77db5
to
f0058be
Compare
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
3 times, most recently
from
4d23274
to
63ec07e
Compare
Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
type changed to list(python) equivalent Signed-off-by: Vemula Venkatesh <venkatesh.vemula@intel.com>
venkyvsp
force-pushed
the
opi_idpool_main_pr
branch
from
63ec07e
to
a5b9763
Compare
idpool feature for generating id's for mod pointer, routing table id , trie pointer.