Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QoS on volume level. #92

Merged

Conversation

artek-koltun
Copy link
Collaborator

Use service implementation from opi-spdk-bridge

@artek-koltun artek-koltun requested a review from intelfisz April 26, 2023 08:16
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #92 (9349c67) into main (c8bc75d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   88.81%   88.88%   +0.07%     
==========================================
  Files           3        3              
  Lines         143      144       +1     
==========================================
+ Hits          127      128       +1     
  Misses         16       16              
Impacted Files Coverage Δ
pkg/middleend/middleend.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Artsiom Koltun <artsiom.koltun@intel.com>
@artek-koltun artek-koltun marked this pull request as ready for review April 26, 2023 08:28
@artek-koltun artek-koltun requested a review from a team as a code owner April 26, 2023 08:28
Copy link
Collaborator

@intelfisz intelfisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code reuse!

@intelfisz intelfisz merged commit 439e048 into opiproject:main Apr 26, 2023
@glimchb
Copy link
Member

glimchb commented Apr 26, 2023

indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants