Compatibility for Beat Saber v1.6.0 and updated to use BSIPA #30
Conversation
There was a problem hiding this comment.
Thank you for the PR!
I can't test if all the messages work right now so I'll try to get that covered later, however I can tell that you made some changes that affected the code style. Please, make your changes adhere to the established style. I marked the first appearance of each mistake to make it easier for you. This is primarily to keep the commit diffs easy to read and the code consistent (and therefore also easier to read).
Other than that it seems like it should work assuming nothing significant changed in the game internals that would make things quietly fail. I'll try to get it tested as soon as I can.
|
Sorry about the styling, everything should be ok now |
|
Almost! There are still two As far as testing goes, it seems I won't be able to handle that myself at least until tomorrow, so I'll try to look into how well BeatMods would handle release candidate versions. Might just let the community test it that way. 👀 |
|
Looks good! If I don't catch anything wrong during testing (when I can) it will get released. Thank you! |
|
o7 |
|
i just tested the changes to see if it works (i've been busy this days) and something might have changed with this game update, because as far as i could test something in OnNoteWasCut seems to fail with this error: I think I fixed that (code in dev branch on my fork), but combos and something else seems to be broken now :/ |
|
Hey fixed that! |
There was a problem hiding this comment.
Sorry for the slow replies. Holidays and other things kept me busy. I left some review comments for the new changes and some issues with the old stuff I missed last time.
Thank you for your patience and once again thanks for the PR. The changes so far should be tested some time this year.
|
|
||
| List<CutScoreBuffer> list = (List<CutScoreBuffer>) afterCutScoreBuffersField.GetValue(scoreController); | ||
| List<CutScoreBuffer> list = (List<CutScoreBuffer>)afterCutScoreBuffersField.GetValue(scoreController); |
| @@ -353,11 +355,17 @@ public class Plugin : IPlugin { | |||
| statusManager.EmitStatusUpdate(ChangedProperties.PerformanceAndNoteCut, "noteMissed"); | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public void OnNoteWasCut2(NoteController noteController, NoteCutInfo noteCutInfo) { | |||
There was a problem hiding this comment.
This is a very undescriptive name. How does it differ from OnNoteWasCut? Also, why is this one necessary and what order are they called in?
Breaks: - `playerSettings.disableSFX` is now `playerSettings.sfxVolume` Changes: - Beat Saber 1.6 support (#30, by @Sarayalth) Adds: - BSIPA support (#30, by @Sarayalth)
|
Published as v1.9.0 and published on BeatMods and GitHub releases, as usual. Unfortunately couldn't do any comprehensive testing, but I trust that you tested it and that it works, especially considering the additional commits you made. Thank you yet again for this PR and sorry for being so slow. Oh, I should also mention that I did look into the whole release candidate thing: BSIPA supports semver version strings correctly and BeatMods seems to have no code that actually checks the format of the version string, so it should be possible. Still, I decided not to do it and decided to just release a patch if anything turns out to still be broken. |
|
Oh, sorry for not responding, i didn't see the notifications. About the OnNoteWasCut2 thing, after some testing that did "work" and i thought it fixed everything, but apparently wasn't processing last cut info. (Score updated to the last to last cut, and rank wasn't working fine) I fixed this after realising that with the change to BSIPA you don't need to subscribe to OnActiveSceneChange, it just works with a method with that name, but couldn't upload the commits as i've been without internet until just now. I'll clean everything and upload in a bit, sorry about all this 🙇. |
|
Merged your changes with the fixes, tested looking at the score and rank, and it's working. Do I open another pr for this changes? |
|
Yes, if you have any more fixes you should open a new PR explaining what issues they fix and how they do it. |
|
Sorry, I read your explanation for |
|
There's an issue with it in v1.9.0, i just sent a pr with a fix for it. The thing is BSIPA don't need And because i didn't know that at the time i started working on this i tested something and found that After realising what was the problem i fixed it and now it works as expected, processing correctly the score and rank of the last cut made. (The mod was displaying score for the cut made before the last cut, and rank/accuracy was completely broken) |
No description provided.