Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: CRL/cert subject hash mismatch in certctl.py #7993

Closed
2 tasks done
fichtner opened this issue Oct 21, 2024 · 1 comment
Closed
2 tasks done

system: CRL/cert subject hash mismatch in certctl.py #7993

fichtner opened this issue Oct 21, 2024 · 1 comment
Assignees
@AdSchellevis
Labels
cleanup Low impact changes
Milestone
25.1

Comments

@fichtner
Copy link
Member

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Describe the bug

Some subjects were producing a different hash in certctl.py after refactor, fixed by d172f15cebb

To Reproduce

Revert commit ;)

Expected behavior

Correct hashing for CRL and certificates

Describe alternatives you considered

N/A

Screenshots

N/A

Relevant log files

N/A

Additional context

N/A

Environment

24.7.6
@fichtner fichtner added the cleanup Low impact changes label Oct 21, 2024
@fichtner fichtner added this to the 25.1 milestone Oct 21, 2024
@AdSchellevis
Copy link
Member

seems to be caused by pyca/pyopenssl#165, fix on its way

fichtner pushed a commit that referenced this issue Oct 21, 2024
@AdSchellevis @fichtner
system: CRL/cert subject hash mismatch in certctl.py, closes #7993
e553cdb 
Since pyOpenSSL doesn't support generating hashses for CRL's, we calculated one with the functions available in the libraries.
Unfortunately X509Name doesn't seem to support duplicate attributes, causing mismatches on our end.

This commit replaces the previous logic with a direct call to openssl, although it's slower, it will deliver the expected outcome.

(cherry picked from commit e78e243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdSchellevis AdSchellevis

Labels
cleanup Low impact changes
Milestone
25.1
Development

No branches or pull requests
2 participants
@fichtner @AdSchellevis