Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable list scroll animation on first render #2489

Closed
mstykow opened this issue Jan 11, 2024 · 0 comments · Fixed by #2490
Closed

Disable list scroll animation on first render #2489

mstykow opened this issue Jan 11, 2024 · 0 comments · Fixed by #2490
Assignees
@mstykow

Comments

@mstykow
Copy link
Member

mstykow commented Jan 11, 2024

Describe the bug
When a virtualized list renders initially with a non-zero topmost item index, it should not show any animation to scroll to this index.

To Reproduce

  1. Open a file with a lot of attributions.
  2. Go to attribution view and scroll down a bit to select an attribution.
  3. Go to audit view and then back to attribution view.
  4. Notice that the list has a "smooth" animation to scroll to the selected attribution position.

Expected behavior
The list immediately renders at the correct position without any animation to scroll there.

Additional context
While the animation is desirable for further interactions, it is distracting when shown on first render.
@mstykow mstykow self-assigned this Jan 11, 2024
@mstykow mstykow changed the title Initial scrolled state of lists should not be animated Disable list scroll animation on first render Jan 11, 2024
mstykow added a commit that referenced this issue Jan 11, 2024
@mstykow
fix: disable list scroll animation on first render
907f59f 
- do not animate list on initial render
- use work-around because of react-virtuoso issue petyosi/react-virtuoso#1001

closes #2489

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow mentioned this issue Jan 11, 2024
Merged
mstykow added a commit that referenced this issue Jan 11, 2024
@mstykow
fix: disable list scroll animation on first render
9e2f4b4 
- do not animate list on initial render
- use work-around because of react-virtuoso issue petyosi/react-virtuoso#1001

closes #2489

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstykow mstykow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable list scroll animation on first render opossum-tool/OpossumUI
1 participant
@mstykow