feat: reset license text #2726
Merged
feat: reset license text #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
commented
Jan 28, 2025
| @@ -5,6 +5,4 @@ | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| . "$(dirname -- "$0")/_/husky.sh" | |||
There was a problem hiding this comment.
warning in console that this line is deprecated and should be removed
There was a problem hiding this comment.
these changes address some deprecation warnings in the MUI Autocomplete component.
- ensure that the license text is reset whenever a new license expression is selected - reset does not occur if a new license expression is typed instead of selected from the available options - new behavior prevents accidental mismatches between expression and text - adjust e2e tests to always write a trace even when successful
mstykow
force-pushed
the
feat-reset-license-text
branch
from
bd0f9f9 to
85661cb
Compare
mstykow
commented
Jan 29, 2025
Comment on lines
+98
to
+100
| path: info.outputPath( | ||
| `${data?.inputData.metadata.projectId || 'app'}.trace.zip`, | ||
| ), |
There was a problem hiding this comment.
create trace even if test succeeds
alexzurbonsen
approved these changes
Jan 30, 2025
| textOverflow: 'ellipsis', | ||
| '&::placeholder': { | ||
| opacity: 1, | ||
| }, |
There was a problem hiding this comment.
I am assuming this just is another (preferrable) way to use the API and doesn't change anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
Closes #2724
How can the changes be tested
Open an opossum file that has a license with custom license text. Then select another suggested license from the autocomplete and notice that the custom license text disappears.