Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExplorationPlayer - Tablet (Portrait) (Highfi) #1173

Closed
MohamedMedhat1998 opened this issue May 28, 2020 · 0 comments · Fixed by #1531
Closed

ExplorationPlayer - Tablet (Portrait) (Highfi) #1173

MohamedMedhat1998 opened this issue May 28, 2020 · 0 comments · Fixed by #1531
Assignees
@MohamedMedhat1998
Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@MohamedMedhat1998
Copy link
Contributor

Mocks: (not ready yet)

Implement high-fi UI for ExplorationPlayer tablet portrait mode

Target PR date: 5 July 2020
Target completion date: 9 July 2020
@MohamedMedhat1998 MohamedMedhat1998 added Where: Exploration player Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. labels May 28, 2020
@MohamedMedhat1998 MohamedMedhat1998 added this to the GSoC 2020 4.1: Milestone 2 milestone May 28, 2020
@MohamedMedhat1998 MohamedMedhat1998 self-assigned this May 28, 2020
@MohamedMedhat1998 MohamedMedhat1998 mentioned this issue Jul 27, 2020
Merged
27 tasks
rt4914 pushed a commit that referenced this issue Jul 28, 2020
@MohamedMedhat1998
Fixes #1171 #1173 #1175 #1177: Exploration/Question player high-fi wo…
6b1a017 
…rk (#1531)

* -prepared the player for high-fi work

* Margin / Padding data binding

* -Followed the suggestion in the PR

* -Fixed lint issues

* -Retrieved deleted by mistake files

* -content_item high-fi

* -continue_navigation_button_item high-fi

* -drag_drop_interaction_item high-fi

* -feedback_item high-fi

* -fraction_interaction_item high-fi

* -next_button_item high-fi

* -numeric_input_interaction_item high-fi

* -previous_button_item high-fi

* -previous_responses_header_item high-fi

* -replay_button_item high-fi

* -return_to_topic_button_item high-fi

* -selection_interaction_item high-fi

* -submit_button_item high-fi

* -submitted_answer_item high-fi

* -text_input_interaction_item high-fi

* -Finished all sub-components high-fi work

* -Finished audio bar high-fi work

* -Finished all player high-fi work

* -Fixed some paddings

* -restored landscape files

* -removed some unnecessary changes

* -Updated the margins in QuestionPlayer

* -some nit changes

* -Fixed lint issues

Co-authored-by: Rajat Talesra <talesra@google.com>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohamedMedhat1998 MohamedMedhat1998

Labels
Priority: Essential This work item must be completed for its milestone. Type: Task A single task of work corresponding to a greater milestone. Generally corresponds to a single PR. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1171 #1173 #1175 #1177: Exploration/Question player high-fi work oppia/oppia-android
2 participants
@MohamedMedhat1998 @BenHenning